client/site_tests/factory_Leds/factory_Leds.py - Issue 2819079: Make test failure messages more verbose (and thus useful to testing operators).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/site_tests/factory_Leds/factory_Leds.py

Issue 2819079: Make test failure messages more verbose (and thus useful to testing operators). (Closed) Base URL: ssh://gitrw.chromium.org/autotest.git

Patch Set: Add more test fail messages Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « client/site_tests/factory_Keyboard/factory_Keyboard.py ('k') | client/site_tests/hardware_GPIOSwitches/hardware_GPIOSwitches.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: client/site_tests/factory_Leds/factory_Leds.py

diff --git a/client/site_tests/factory_Leds/factory_Leds.py b/client/site_tests/factory_Leds/factory_Leds.py

index d31f147c64f41c918d62994fa9996420f5024ede..77ba481ef84a991cca7b49e143cce494ad60e17c 100644

--- a/client/site_tests/factory_Leds/factory_Leds.py

+++ b/client/site_tests/factory_Leds/factory_Leds.py

@@ -177,12 +177,19 @@ class factory_Leds(test.test):

factory.log('%s run_once' % self.__class__)

self._led_ctl_path = led_ctl_path

+ if not os.path.exists(self._led_ctl_path):

+ raise error.TestNAError('Command %s does not exist' %

+ self._led_ctl_path)

self._shift_color = ful.BLACK

self._shift_cnt = 0

os.chdir(self.srcdir)

- image = cairo.ImageSurface.create_from_png('leds.png')

+ try:

+ image = cairo.ImageSurface.create_from_png('leds.png')

+ except cairo.Error as e:

+ raise error.TestNAError('Error while opening leds.png: %s' %

+ e.message)

image_size = (image.get_width(), image.get_height())

self._leds_image = image