Issue 2819072: Fixed extension sync-related crash in ChromeUrlRequestContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2819072: Fixed extension sync-related crash in ChromeUrlRequestContext (Closed)

Created:
10 years, 4 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Fixed extension sync-related crash in ChromeUrlRequestContext Made ChromeUrlRequestContext handle multiple extension unloaded notifications gracefully. BUG=50567 TEST=manual (see repro in bug) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54100

Patch Set 1 #

Patch Set 2 : simplified code #

Patch Set 3 : Addressed erikkay's comments #

Total comments: 1

Patch Set 4 : Addressed erikkay's comments #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	chrome/browser/net/chrome_url_request_context.cc	View	1 2 3	1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

LGTM http://codereview.chromium.org/2819072/diff/7001/8001 File chrome/browser/net/chrome_url_request_context.cc (right): http://codereview.chromium.org/2819072/diff/7001/8001#newcode847 chrome/browser/net/chrome_url_request_context.cc:847: NOTREACHED() << id; Add a comment and reference ...

10 years, 4 months ago (2010-07-29 00:11:42 UTC) #2

akalin

10 years, 4 months ago (2010-07-29 00:17:03 UTC) #3

Done, checking in as soon as trybots pass.

On 2010/07/29 00:11:42, Erik Kay wrote:
> LGTM
> 
> http://codereview.chromium.org/2819072/diff/7001/8001
> File chrome/browser/net/chrome_url_request_context.cc (right):
> 
> http://codereview.chromium.org/2819072/diff/7001/8001#newcode847
> chrome/browser/net/chrome_url_request_context.cc:847: NOTREACHED() << id;
> Add a comment and reference the new bug you file about this.

Expand Messages | Collapse Messages