Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2819063: Cleanup: Remove unneeded headers from app/ (Closed)

Created:
10 years, 5 months ago by Lei Zhang
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, kuchhal, native-client-reviews_googlegroups.com, ncarter (slow), dpranke+watch_chromium.org, Alpha Left Google, Erik does not do reviews, jam, apatrick_chromium, dhg, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), ben+cc_chromium.org, Raghu Simha, Paul Godavari, cbentzel+watch_chromium.org, pam+watch_chromium.org, awong, scherkus (not reviewing), idana, Aaron Boodman, Paweł Hajdan Jr.
Visibility:
Public.

Description

Cleanup: Remove unneeded headers from app/ BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54102

Patch Set 1 : '' #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : forward declare #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -120 lines) Patch
M app/animation_container.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M app/gfx/gl/gl_implementation_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M app/l10n_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M app/l10n_util_dummy.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M app/l10n_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/linear_animation.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M app/resource_bundle_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M app/text_elider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M app/text_elider_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/app_modal_dialog_gtk.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_profile_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_drag_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/browser_theme_pack_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bug_report_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/cookie_modal_dialog_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cookies_tree_model.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/cookies_tree_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/diagnostics/sqlite_diagnostics.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/app_launcher_handler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/dom_ui/core_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/downloads_dom_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/fileicon_source.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/mediaplayer_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/personal_options_handler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/dom_ui/register_page_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/slideshow_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/sync_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_file.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_infobar_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/archived_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/download_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/starred_url_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/text_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/url_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/visit_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/visitsegment_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/importer/importer_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/language_order_table_model.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/language_order_table_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store.h View 1 chunk +4 lines, -1 line 0 comments Download
MM chrome/browser/notifications/notification_exceptions_table_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/platform_util_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/possible_url_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/pref_value_store_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profile.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profile_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_painting_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/session_history_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_policy.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/directory_backing_store_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/toolbar_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/utility_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/visitedlink_master.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/wrench_menu_model.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_localization_peer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_message_bundle_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/gpu_messages.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/json_pref_store_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/time_format_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/gpu/gpu_backing_store_glx.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/gpu/gpu_video_layer_glx.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/extensions/renderer_extension_bindings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/database/databases_table.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/database/quota_table.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/mock_webclipboard_impl.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
10 years, 4 months ago (2010-07-28 22:54:25 UTC) #1
Elliot Glaysher
Rubber stamp of AWESOME. http://codereview.chromium.org/2819063/diff/26008/40035 File chrome/browser/dom_ui/fileicon_source.h (right): http://codereview.chromium.org/2819063/diff/26008/40035#newcode11 chrome/browser/dom_ui/fileicon_source.h:11: #include "base/ref_counted_memory.h" Forward declare RefCountedBytes ...
10 years, 4 months ago (2010-07-28 23:36:09 UTC) #2
Lei Zhang
On 2010/07/28 23:36:09, Elliot Glaysher wrote: > Rubber stamp of AWESOME. > > http://codereview.chromium.org/2819063/diff/26008/40035 > ...
10 years, 4 months ago (2010-07-29 00:02:10 UTC) #3
fbarchard
LGTM assuming it builds. This is great! Do more if you can! I wonder if ...
10 years, 4 months ago (2010-07-29 05:19:17 UTC) #4
Elliot Glaysher
10 years, 4 months ago (2010-07-29 06:53:43 UTC) #5
> Expect a few more of these patches. It's happening on spare time while I
> wait
> for other stuff to compile.

I'm just happy to have any help on this task.

-- Elliot

Powered by Google App Engine
This is Rietveld 408576698