Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: cros_mark_as_stable.py

Issue 2819052: Return error when error occurs by raising exception (Closed) Base URL: ssh://git@chromiumos-git//crosutils.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cros_mark_as_stable.py
diff --git a/cros_mark_as_stable.py b/cros_mark_as_stable.py
index dd3192cb5097f3166c8c95eb4663c1b44d92bb9e..df87985a9a6f981ce96a52ef253b4117427d9323 100755
--- a/cros_mark_as_stable.py
+++ b/cros_mark_as_stable.py
@@ -315,9 +315,9 @@ def main(argv):
except gflags.FlagsError, e :
_PrintUsageAndDie(str(e))
- package_list = gflags.FLAGS.packages.split(' ')
+ package_list = gflags.FLAGS.packages.split()
if gflags.FLAGS.commit_ids:
- commit_id_list = gflags.FLAGS.commit_ids.split(' ')
+ commit_id_list = gflags.FLAGS.commit_ids.split()
else:
commit_id_list = None
_CheckSaneArguments(package_list, commit_id_list, command)
@@ -347,11 +347,12 @@ def main(argv):
worker.CommitChange(_GIT_COMMIT_MESSAGE % (package, commit_id))
except (OSError, IOError), e:
- print ('An exception occurred %s\n'
+ print ('An exception occurred\n'
'Only the following packages were revved: %s\n'
'Note you will have to go into %s'
'and reset the git repo yourself.' %
- (e, package_list[:index], _CHROMIUMOS_OVERLAYS_DIRECTORY))
+ (package_list[:index], _CHROMIUMOS_OVERLAYS_DIRECTORY))
+ raise e
elif command == 'push':
_PushChange()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698