Hide the autocomplete popup when no suggestions are available

chrome/renderer/render_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 1496 matching lines @@
 void RenderView::AddGURLSearchProvider(const GURL& osd_url, bool autodetected) {
   if (!osd_url.is_empty())
     Send(new ViewHostMsg_PageHasOSDD(routing_id_, page_id_, osd_url,
                                      autodetected));
 }
 
 void RenderView::OnAutoFillSuggestionsReturned(
     int query_id,
     const std::vector<string16>& values,
     const std::vector<string16>& labels) {
-  if (webview() && query_id == autofill_query_id_) {
-    std::vector<string16> v(values);
-    std::vector<string16> l(labels);
-    int separator_index = -1;
+  if (!webview() || query_id != autofill_query_id_)
+    return;
 
-    // The form has been auto-filled, so give the user the chance to clear the
-    // form.  Append the 'Clear form' menu item.
-    if (form_manager_.FormWithNodeIsAutoFilled(autofill_query_node_)) {
-      v.push_back(l10n_util::GetStringUTF16(IDS_AUTOFILL_CLEAR_FORM_MENU_ITEM));
-      l.push_back(string16());
-      suggestions_clear_index_ = v.size() - 1;
-      separator_index = values.size();
-    }
+  // Any popup currently showing is now obsolete.
+  webview()->hidePopups();
+  
+  std::vector<string16> v(values);
+  std::vector<string16> l(labels);
+  int separator_index = -1;
 
-    size_t labeled_item_count = 0;
-    for (size_t i = 0; i < l.size(); ++i) {
-      if (!l[i].empty())
-        labeled_item_count++;
-    }
+  // The form has been auto-filled, so give the user the chance to clear the
+  // form.  Append the 'Clear form' menu item.
+  if (form_manager_.FormWithNodeIsAutoFilled(autofill_query_node_)) {
+    v.push_back(l10n_util::GetStringUTF16(IDS_AUTOFILL_CLEAR_FORM_MENU_ITEM));
+    l.push_back(string16());
+    suggestions_clear_index_ = v.size() - 1;
+    separator_index = values.size();
+  }
 
-    // Only include "AutoFill Options" special menu item if we have labeled
-    // items.
-    if (labeled_item_count > 0) {
-      // Append the 'AutoFill Options...' menu item.
-      v.push_back(l10n_util::GetStringUTF16(IDS_AUTOFILL_OPTIONS));
-      l.push_back(string16());
-      suggestions_options_index_ = v.size() - 1;
-      separator_index = values.size();
-    }
+  size_t labeled_item_count = 0;
+  for (size_t i = 0; i < l.size(); ++i) {
+    if (!l[i].empty())
+      labeled_item_count++;
+  }
 
-    // Send to WebKit for display.
-    if (!v.empty())
-      webview()->applyAutoFillSuggestions(
-          autofill_query_node_, v, l, separator_index);
+  // Only include "AutoFill Options" special menu item if we have labeled
+  // items.
+  if (labeled_item_count > 0) {
+    // Append the 'AutoFill Options...' menu item.
+    v.push_back(l10n_util::GetStringUTF16(IDS_AUTOFILL_OPTIONS));
+    l.push_back(string16());
+    suggestions_options_index_ = v.size() - 1;
+    separator_index = values.size();
   }
+
+  // Send to WebKit for display.
+  if (!v.empty())
+    webview()->applyAutoFillSuggestions(
+        autofill_query_node_, v, l, separator_index);
 }
 
 void RenderView::OnAutoFillFormDataFilled(int query_id,
                                           const webkit_glue::FormData& form) {
   if (!webview() || query_id != autofill_query_id_)
     return;
 
   DCHECK_NE(AUTOFILL_NONE, autofill_action_);
 
   if (autofill_action_ == AUTOFILL_FILL)
@@ skipping 3751 matching lines @@
   webkit_glue::FormData form;
   const WebInputElement element = node.toConst<WebInputElement>();
   if (!form_manager_.FindFormWithFormControlElement(
           element, FormManager::REQUIRE_NONE, &form))
     return;
 
   autofill_action_ = action;
   Send(new ViewHostMsg_FillAutoFillFormData(
       routing_id_, autofill_query_id_, form, value, label));
 }