Issue 2819050: Deal with alpha values when building PNG in chrome.tabs.captureVisibleTab().

Issue 2819050: Deal with alpha values when building PNG in chrome.tabs.captureVisibleTab(). (Closed)

Created:
10 years, 5 months ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Deal with alpha values when building PNG in chrome.tabs.captureVisibleTab(). BUG=44758 TEST=ExtensionApiTest.CaptureVisibleTab, try taking a snapshot of google.com on mac, linux, win. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52931

Patch Set 1 #

Patch Set 2 : Add testing. #

Patch Set 3 : Rebase #

Total comments: 1

Patch Set 4 : Rerebase. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -39 lines)			Patch
M	chrome/browser/extensions/extension_tabs_module.cc	View	1	3 chunks	+8 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/red.html	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js	View		5 chunks	+65 lines, -28 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/text.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sam Kerner (Chrome)

http://codereview.chromium.org/2819050/diff/5001/6002 File chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js (left): http://codereview.chromium.org/2819050/diff/5001/6002#oldcode119 chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js:119: //testAllPixelsAreExpectedColor(imgDataUrl, On our XP bots, there are a limited ...

10 years, 5 months ago (2010-07-19 14:34:05 UTC) #2

asargent_no_longer_on_chrome

lgtm - it would be great to get rid of flakiness of this test :)

10 years, 5 months ago (2010-07-19 18:19:17 UTC) #4

skerner

10 years, 5 months ago (2010-07-19 18:30:32 UTC) #5

On Mon, Jul 19, 2010 at 2:19 PM,  <asargent@chromium.org> wrote:
> lgtm - it would be great to get rid of flakiness of this test :)

I read that as volunteering to review the next CL I will be sending out :)

Expand Messages | Collapse Messages