Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2819039: remove autotests in case they come back (Closed)

Created:
10 years, 5 months ago by Nick Sanders
Modified:
9 years, 7 months ago
Reviewers:
ericli, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://gitrw.chromium.org/crosutils.git
Visibility:
Public.

Description

remove autotests in case they come back BUG=4514 TEST=build factory image

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M mod_image_for_test.sh View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Nick Sanders
This deletes extra autotest files, if you want to check in the package thing. Is ...
10 years, 5 months ago (2010-07-03 01:03:03 UTC) #1
ericli
http://codereview.chromium.org/2819039/diff/1/2 File mod_image_for_test.sh (right): http://codereview.chromium.org/2819039/diff/1/2#newcode121 mod_image_for_test.sh:121: sudo rm -rf "${stateful_root}/lib/icedtea6" || true why icetea6 here? ...
10 years, 5 months ago (2010-07-03 02:04:47 UTC) #2
Nick Sanders
http://codereview.chromium.org/2819039/diff/1/2 File mod_image_for_test.sh (right): http://codereview.chromium.org/2819039/diff/1/2#newcode121 mod_image_for_test.sh:121: sudo rm -rf "${stateful_root}/lib/icedtea6" || true On 2010/07/03 02:04:47, ...
10 years, 5 months ago (2010-07-04 01:37:54 UTC) #3
ericli
10 years, 5 months ago (2010-07-04 02:14:40 UTC) #4
LGTM.

On 2010/07/04 01:37:54, Nick Sanders wrote:
> http://codereview.chromium.org/2819039/diff/1/2
> File mod_image_for_test.sh (right):
> 
> http://codereview.chromium.org/2819039/diff/1/2#newcode121
> mod_image_for_test.sh:121: sudo rm -rf "${stateful_root}/lib/icedtea6" || true
> On 2010/07/03 02:04:47, ericli wrote:
> > why icetea6 here?
> From factory perspective, it's 150+MB of useless stuff that we don't need to
DL
> onto every machine.

Powered by Google App Engine
This is Rietveld 408576698