Issue 2819031: Linux: Undo a bit of tcmalloc gyp change from r49597....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2819031: Linux: Undo a bit of tcmalloc gyp change from r49597.... (Closed)

Created:
10 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, Evan Martin, bradn

CC:
chromium-reviews, brettw-cc_chromium.org, jam, Mark Mentovai

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: Undo a bit of tcmalloc gyp change from r49597. The reverted change puts direct_dependent_settings inside a configuration dictionary, which is invalid. BUG=45067 TEST=GYP_DEFINES='linux_use_tcmalloc=0' gclient runhooks works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51470

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	base/base.gypi	View		2 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Can you describe why in the changelog? LGTM otherwise

10 years, 5 months ago (2010-07-01 01:49:09 UTC) #2

Ah, yes, that's better.
LGTM

Expand Messages | Collapse Messages