Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 2819029: Re-enable ConcurrencyTest (Closed)

Created:
10 years, 5 months ago by davidben
Modified:
9 years, 6 months ago
Reviewers:
agl
CC:
chromium-reviews, Alexander Potapenko, Timur Iskhodzhanov, cbentzel+watch_chromium.org, stuartmorgan, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-enable ConcurrencyTest We disable it under Valgrind because it takes a while. The Chrome OS crash was resolved in r51091. R=agl BUG=37289, 47587 TEST=KeygenHandler.ConcurrencyTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M net/base/keygen_handler_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/data/valgrind/net_unittests.gtest.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidben
Uploading this now so I don't forget. It's blocking on http://codereview.chromium.org/2873027/show which fixes the Chrome ...
10 years, 5 months ago (2010-06-29 01:59:57 UTC) #1
agl
10 years, 5 months ago (2010-06-29 14:17:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698