chrome/browser/extensions/test_extension_prefs.cc - Issue 2819023: Reworked ExtensionsService::AddPendingExtension().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/test_extension_prefs.cc

Issue 2819023: Reworked ExtensionsService::AddPendingExtension(). (Closed)

Patch Set: Fixed browsertest test failure Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/test_extension_prefs.cc

diff --git a/chrome/browser/extensions/test_extension_prefs.cc b/chrome/browser/extensions/test_extension_prefs.cc

index 5a0c9f82c1a182f0f8ce38014f91cbc7f58d277f..97c47e8144c1ffb5ad8307c6fa025b5e8295f855 100644

--- a/chrome/browser/extensions/test_extension_prefs.cc

+++ b/chrome/browser/extensions/test_extension_prefs.cc

@@ -69,7 +69,9 @@ Extension* TestExtensionPrefs::AddExtensionWithManifest(

EXPECT_TRUE(extension->InitFromValue(manifest, false, &errors));

extension->set_location(Extension::INTERNAL);

EXPECT_TRUE(Extension::IdIsValid(extension->id()));

- prefs_->OnExtensionInstalled(extension);

+ const bool kInitialIncognitoEnabled = false;

+ prefs_->OnExtensionInstalled(extension, Extension::ENABLED,

+ kInitialIncognitoEnabled);

return extension;

}