Issue 2819013: Fixed memleak in JsonHostConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2819013: Fixed memleak in JsonHostConfig. (Closed)

Created:
10 years, 6 months ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, pam+watch_chromium.org, awong, garykac

Visibility:
Public.

Description

Fixed memleak in JsonHostConfig. BUG=46882 TEST=heapcheck on remoting_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50270

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -21 lines)			Patch
	M	remoting/host/json_host_config.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	tools/heapcheck/suppressions.txt	View		1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

LGTM. Can you run valgrind on it to make sure we don't leak? you can ...

10 years, 6 months ago (2010-06-18 18:54:48 UTC) #2

Sergey Ulanov

10 years, 6 months ago (2010-06-18 19:07:30 UTC) #3

On Fri, Jun 18, 2010 at 11:54 AM, <hclam@chromium.org> wrote:

> LGTM. Can you run valgrind on it to make sure we don't leak?
>
> you can use tools/valgrind/chrome_tests.sh -t remoting

Yes, I tried heapcheck, it doesn't leak with this change.

Expand Messages | Collapse Messages