Issue 2819004: Ensure that the default make target is always first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2819004: Ensure that the default make target is always first. (Closed)

Created:
10 years, 6 months ago by vb

Modified:
9 years, 6 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/vboot_reference.git

Visibility:
Public.

Description

One of the last moment mods of the original make rework CL (http://codereview.chromium.org/2845001) resulted in broken dependencies. This CL completes the modification (the trick is to ensure that the default target is always the first). Note that the tests subdirectory Makefile still does not properly follow the dependencies, it will have to be addressed in a separate CL. Tested by touching different .h and .c files and observing the results.

Patch Set 1 : vboot_referece make fix. #

Patch Set 2 : Rebased with recent changes. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
M	cgpt/Makefile	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	common.mk	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	misclibs/Makefile	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	utility/Makefile	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	vkernel/Makefile	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages