Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2818045: Use the new developer keys to sign things. (submit for Bill) (Closed)

Created:
10 years, 5 months ago by Louis
Modified:
9 years, 4 months ago
Reviewers:
Hung-Te
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://gitrw.chromium.org/crosutils.git
Visibility:
Public.

Description

Use the new developer keys to sign things. (submit for Bill) The original CL is http://codereview.chromium.org/2868044/show

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed indetns #

Total comments: 4

Patch Set 3 : fixed indet and column 80 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -63 lines) Patch
M build_image View 5 chunks +10 lines, -8 lines 0 comments Download
M build_kernel_image.sh View 1 2 3 chunks +33 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Louis
10 years, 5 months ago (2010-07-05 05:03:20 UTC) #1
Hung-Te
LGTM except some indent issues http://codereview.chromium.org/2818045/diff/1/3 File build_kernel_image.sh (right): http://codereview.chromium.org/2818045/diff/1/3#newcode151 build_kernel_image.sh:151: --signpubkey "${FLAGS_keys_dir}/recovery_key.vbpubk" indent different ...
10 years, 5 months ago (2010-07-05 05:09:16 UTC) #2
Louis
10 years, 5 months ago (2010-07-05 05:13:00 UTC) #3
Louis
thanks. fixed. http://codereview.chromium.org/2818045/diff/1/3 File build_kernel_image.sh (right): http://codereview.chromium.org/2818045/diff/1/3#newcode151 build_kernel_image.sh:151: --signpubkey "${FLAGS_keys_dir}/recovery_key.vbpubk" On 2010/07/05 05:09:16, Hung-Te wrote: ...
10 years, 5 months ago (2010-07-05 05:13:14 UTC) #4
Hung-Te
LGTM except some minor indent/column 80s http://codereview.chromium.org/2818045/diff/5001/6002 File build_kernel_image.sh (right): http://codereview.chromium.org/2818045/diff/5001/6002#newcode136 build_kernel_image.sh:136: # USB key. ...
10 years, 5 months ago (2010-07-05 05:17:40 UTC) #5
Louis
thanks. fixed. http://codereview.chromium.org/2818045/diff/5001/6002 File build_kernel_image.sh (right): http://codereview.chromium.org/2818045/diff/5001/6002#newcode136 build_kernel_image.sh:136: # USB key. We can only boot ...
10 years, 5 months ago (2010-07-05 05:22:06 UTC) #6
Louis
10 years, 5 months ago (2010-07-05 05:22:13 UTC) #7
Hung-Te
10 years, 5 months ago (2010-07-05 05:23:04 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698