Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: src/utils.h

Issue 2818028: Change kMinComplexMemCopy to 64 for IA32. It's just better. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 569 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 (*memcopy)(dest, src, size); 580 (*memcopy)(dest, src, size);
581 #ifdef DEBUG 581 #ifdef DEBUG
582 CHECK_EQ(0, memcmp(dest, src, size)); 582 CHECK_EQ(0, memcmp(dest, src, size));
583 #endif 583 #endif
584 } 584 }
585 585
586 586
587 // Limit below which the extra overhead of the MemCopy function is likely 587 // Limit below which the extra overhead of the MemCopy function is likely
588 // to outweigh the benefits of faster copying. 588 // to outweigh the benefits of faster copying.
589 // TODO(lrn): Try to find a more precise value. 589 // TODO(lrn): Try to find a more precise value.
590 static const int kMinComplexMemCopy = 256; 590 static const int kMinComplexMemCopy = 64;
591 591
592 #else // V8_TARGET_ARCH_IA32 592 #else // V8_TARGET_ARCH_IA32
593 593
594 static inline void MemCopy(void* dest, const void* src, size_t size) { 594 static inline void MemCopy(void* dest, const void* src, size_t size) {
595 memcpy(dest, src, size); 595 memcpy(dest, src, size);
596 } 596 }
597 597
598 static const int kMinComplexMemCopy = 256; 598 static const int kMinComplexMemCopy = 256;
599 599
600 #endif // V8_TARGET_ARCH_IA32 600 #endif // V8_TARGET_ARCH_IA32
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 736
737 Dest dest; 737 Dest dest;
738 memcpy(&dest, &source, sizeof(dest)); 738 memcpy(&dest, &source, sizeof(dest));
739 return dest; 739 return dest;
740 } 740 }
741 741
742 } } // namespace v8::internal 742 } } // namespace v8::internal
743 743
744 744
745 #endif // V8_UTILS_H_ 745 #endif // V8_UTILS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698