Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 2818026: X64: A bunch of small fixes. (Closed)
Patch Set: Addressed review comments. As discussed, also fix call/jmp. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/macro-assembler-x64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1660 matching lines...) Expand 10 before | Expand all | Expand 10 after
1671 } 1671 }
1672 1672
1673 1673
1674 void MacroAssembler::Ret() { 1674 void MacroAssembler::Ret() {
1675 ret(0); 1675 ret(0);
1676 } 1676 }
1677 1677
1678 1678
1679 void MacroAssembler::FCmp() { 1679 void MacroAssembler::FCmp() {
1680 fucomip(); 1680 fucomip();
1681 ffree(0); 1681 fstp(0);
1682 fincstp();
1683 } 1682 }
1684 1683
1685 1684
1686 void MacroAssembler::CmpObjectType(Register heap_object, 1685 void MacroAssembler::CmpObjectType(Register heap_object,
1687 InstanceType type, 1686 InstanceType type,
1688 Register map) { 1687 Register map) {
1689 movq(map, FieldOperand(heap_object, HeapObject::kMapOffset)); 1688 movq(map, FieldOperand(heap_object, HeapObject::kMapOffset));
1690 CmpInstanceType(map, type); 1689 CmpInstanceType(map, type);
1691 } 1690 }
1692 1691
(...skipping 1063 matching lines...) Expand 10 before | Expand all | Expand 10 after
2756 CPU::FlushICache(address_, size_); 2755 CPU::FlushICache(address_, size_);
2757 2756
2758 // Check that the code was patched as expected. 2757 // Check that the code was patched as expected.
2759 ASSERT(masm_.pc_ == address_ + size_); 2758 ASSERT(masm_.pc_ == address_ + size_);
2760 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap); 2759 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
2761 } 2760 }
2762 2761
2763 } } // namespace v8::internal 2762 } } // namespace v8::internal
2764 2763
2765 #endif // V8_TARGET_ARCH_X64 2764 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/macro-assembler-x64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698