Issue 2818023: Augment trace-ic to provide information on patching inlined loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2818023: Augment trace-ic to provide information on patching inlined loads. (Closed)

Created:
10 years, 6 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Augment trace-ic to provide information on patching inlined loads. Committed: http://code.google.com/p/v8/source/detail?r=4915

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	src/ic.cc	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM How about the other types which can be inlined? http://codereview.chromium.org/2818023/diff/1/2 File src/ic.cc (right): http://codereview.chromium.org/2818023/diff/1/2#newcode734 ...

10 years, 6 months ago (2010-06-22 10:20:49 UTC) #2

Erik Corry

10 years, 6 months ago (2010-06-22 12:12:22 UTC) #3

I didn't do the other inlined cases.  Another time perhaps.

I put the logging in ifdefs so it doesn't go in the release version.

http://codereview.chromium.org/2818023/diff/1/2
File src/ic.cc (right):

http://codereview.chromium.org/2818023/diff/1/2#newcode734
src/ic.cc:734: if (FLAG_trace_ic) PrintF("[LoadIC : patch %s ]\n",
*name->ToCString());
On 2010/06/22 10:20:49, Søren Gjesse wrote:
> Maybe remove this line.

Done.

Expand Messages | Collapse Messages