Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2818021: Adding blacklist support for unit tests and blacklisting currently failing tests. (Closed)

Created:
10 years, 6 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git//crosutils.git
Visibility:
Public.

Description

Adding blacklist support for unit tests and blacklisting currently failing tests. TEST=Ran cros_run_unit_tests with no arguments and it returned 0.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Petov's changes #

Patch Set 3 : Power_manager works. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M cros_run_unit_tests View 1 1 chunk +6 lines, -0 lines 0 comments Download
A unit_test_black_list.txt View 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sosa
10 years, 6 months ago (2010-06-21 22:33:24 UTC) #1
petkov
http://codereview.chromium.org/2818021/diff/1/2 File cros_run_unit_tests (right): http://codereview.chromium.org/2818021/diff/1/2#newcode69 cros_run_unit_tests:69: if egrep "${package}" "${BLACK_LIST_FILE}"; then maybe grep -q -x ...
10 years, 6 months ago (2010-06-21 23:09:02 UTC) #2
sosa
http://codereview.chromium.org/2818021/diff/1/2 File cros_run_unit_tests (right): http://codereview.chromium.org/2818021/diff/1/2#newcode69 cros_run_unit_tests:69: if egrep "${package}" "${BLACK_LIST_FILE}"; then On 2010/06/21 23:09:02, petkov ...
10 years, 6 months ago (2010-06-22 00:35:23 UTC) #3
petkov
10 years, 6 months ago (2010-06-22 00:37:04 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698