Issue 28177: Add hunspell.gyp and add spellchecker.cc to chrome.gyp:browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28177: Add hunspell.gyp and add spellchecker.cc to chrome.gyp:browser (Closed)

Created:
11 years, 10 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (Google), Scott Hess - ex-Googler

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Add hunspell.gyp and add spellchecker.cc to chrome.gyp:browser Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10454

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -1 line)			Patch
	M	chrome/chrome.gyp	View		2 chunks	+1 line, -1 line	0 comments	Download
	A	chrome/third_party/hunspell/hunspell.gyp	View		1 chunk	+58 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

11 years, 10 months ago (2009-02-26 14:38:07 UTC) #2

LGTM.

I don't know what would look BAD to me in this case!

I have a change to get the spellchecker unit test running, I assume it's
appropriate to get both xcodeproj and gyp running it?  It involves a runscript,
though, so I'll probably need to ask questions...

http://codereview.chromium.org/28177/diff/1/2
File chrome/third_party/hunspell/hunspell.gyp (right):

http://codereview.chromium.org/28177/diff/1/2#newcode19
Line 19: 'OPENOFFICEORG',
SConscript also defines CHROME_SPELL.  I do not know why.

http://codereview.chromium.org/28177/diff/1/2#newcode48
Line 48: 'src/parsers/textparser.hxx',
SConscript doesn't mention them, but there are a couple of non-include files
included in the .cxx files,  license.hunspell and license.myspell.  Don't know
if those should be mentioned?

Expand Messages | Collapse Messages