net/proxy/proxy_resolver_winhttp.cc - Issue 2817043: Reduce the copying of string data between C++ and javascript in proxy_resolver_v8.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_winhttp.cc

Issue 2817043: Reduce the copying of string data between C++ and javascript in proxy_resolver_v8.cc. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix comment typo 'converts' Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_resolver_winhttp.cc

===================================================================

--- net/proxy/proxy_resolver_winhttp.cc (revision 51195)

+++ net/proxy/proxy_resolver_winhttp.cc (working copy)

@@ -141,7 +141,7 @@

}

int ProxyResolverWinHttp::SetPacScript(const GURL& pac_url,

- const std::string& /*pac_bytes*/,

+ const string16& /*pac_script*/,

CompletionCallback* /*callback*/) {

pac_url_ = pac_url.is_valid() ? pac_url : GURL("http://wpad/wpad.dat");

return OK;

« no previous file with comments | « net/proxy/proxy_resolver_winhttp.h ('k') | net/proxy/proxy_script_fetcher.h » ('j') | no next file with comments »