Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: net/proxy/proxy_service.cc

Issue 2817043: Reduce the copying of string data between C++ and javascript in proxy_resolver_v8.cc. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix comment typo 'converts' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/proxy/proxy_script_fetcher_unittest.cc ('k') | net/proxy/proxy_service_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/proxy/proxy_service.h" 5 #include "net/proxy/proxy_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 const BoundNetLog& net_log) { 62 const BoundNetLog& net_log) {
63 return ERR_NOT_IMPLEMENTED; 63 return ERR_NOT_IMPLEMENTED;
64 } 64 }
65 65
66 virtual void CancelRequest(RequestHandle request) { 66 virtual void CancelRequest(RequestHandle request) {
67 NOTREACHED(); 67 NOTREACHED();
68 } 68 }
69 69
70 private: 70 private:
71 virtual int SetPacScript(const GURL& /*pac_url*/, 71 virtual int SetPacScript(const GURL& /*pac_url*/,
72 const std::string& /*pac_bytes*/, 72 const string16& /*pac_script*/,
73 CompletionCallback* /*callback*/) { 73 CompletionCallback* /*callback*/) {
74 return ERR_NOT_IMPLEMENTED; 74 return ERR_NOT_IMPLEMENTED;
75 } 75 }
76 }; 76 };
77 77
78 // ProxyService::PacRequest --------------------------------------------------- 78 // ProxyService::PacRequest ---------------------------------------------------
79 79
80 class ProxyService::PacRequest 80 class ProxyService::PacRequest
81 : public base::RefCounted<ProxyService::PacRequest> { 81 : public base::RefCounted<ProxyService::PacRequest> {
82 public: 82 public:
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
730 OnCompletion(result_); 730 OnCompletion(result_);
731 } 731 }
732 } 732 }
733 733
734 void SyncProxyServiceHelper::OnCompletion(int rv) { 734 void SyncProxyServiceHelper::OnCompletion(int rv) {
735 result_ = rv; 735 result_ = rv;
736 event_.Signal(); 736 event_.Signal();
737 } 737 }
738 738
739 } // namespace net 739 } // namespace net
OLDNEW
« no previous file with comments | « net/proxy/proxy_script_fetcher_unittest.cc ('k') | net/proxy/proxy_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698