Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: net/proxy/proxy_resolver_v8.h

Issue 2817043: Reduce the copying of string data between C++ and javascript in proxy_resolver_v8.cc. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix comment typo 'converts' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/proxy/proxy_resolver_perftest.cc ('k') | net/proxy/proxy_resolver_v8.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_PROXY_PROXY_RESOLVER_V8_H_ 5 #ifndef NET_PROXY_PROXY_RESOLVER_V8_H_
6 #define NET_PROXY_PROXY_RESOLVER_V8_H_ 6 #define NET_PROXY_PROXY_RESOLVER_V8_H_
7 7
8 #include <string>
9
10 #include "base/scoped_ptr.h" 8 #include "base/scoped_ptr.h"
11 #include "net/proxy/proxy_resolver.h" 9 #include "net/proxy/proxy_resolver.h"
12 10
13 class MessageLoop; 11 class MessageLoop;
14 12
15 namespace net { 13 namespace net {
16 14
17 class HostResolver; 15 class HostResolver;
18 class ProxyResolverJSBindings; 16 class ProxyResolverJSBindings;
19 17
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 ProxyResolverJSBindings* js_bindings() const { return js_bindings_.get(); } 54 ProxyResolverJSBindings* js_bindings() const { return js_bindings_.get(); }
57 55
58 private: 56 private:
59 // Context holds the Javascript state for the most recently loaded PAC 57 // Context holds the Javascript state for the most recently loaded PAC
60 // script. It corresponds with the data from the last call to 58 // script. It corresponds with the data from the last call to
61 // SetPacScript(). 59 // SetPacScript().
62 class Context; 60 class Context;
63 61
64 // ProxyResolver implementation: 62 // ProxyResolver implementation:
65 virtual int SetPacScript(const GURL& /*pac_url*/, 63 virtual int SetPacScript(const GURL& /*pac_url*/,
66 const std::string& bytes_utf8, 64 const string16& pac_script,
67 CompletionCallback* /*callback*/); 65 CompletionCallback* /*callback*/);
68 scoped_ptr<Context> context_; 66 scoped_ptr<Context> context_;
69 67
70 scoped_ptr<ProxyResolverJSBindings> js_bindings_; 68 scoped_ptr<ProxyResolverJSBindings> js_bindings_;
71 69
72 DISALLOW_COPY_AND_ASSIGN(ProxyResolverV8); 70 DISALLOW_COPY_AND_ASSIGN(ProxyResolverV8);
73 }; 71 };
74 72
75 } // namespace net 73 } // namespace net
76 74
77 #endif // NET_PROXY_PROXY_RESOLVER_V8_H_ 75 #endif // NET_PROXY_PROXY_RESOLVER_V8_H_
OLDNEW
« no previous file with comments | « net/proxy/proxy_resolver_perftest.cc ('k') | net/proxy/proxy_resolver_v8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698