Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: net/proxy/proxy_resolver_mac.h

Issue 2817043: Reduce the copying of string data between C++ and javascript in proxy_resolver_v8.cc. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix comment typo 'converts' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/proxy/proxy_resolver.h ('k') | net/proxy/proxy_resolver_perftest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_PROXY_PROXY_RESOLVER_MAC_H_ 5 #ifndef NET_PROXY_PROXY_RESOLVER_MAC_H_
6 #define NET_PROXY_PROXY_RESOLVER_MAC_H_ 6 #define NET_PROXY_PROXY_RESOLVER_MAC_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "googleurl/src/gurl.h" 10 #include "googleurl/src/gurl.h"
(...skipping 14 matching lines...) Expand all
25 CompletionCallback* callback, 25 CompletionCallback* callback,
26 RequestHandle* request, 26 RequestHandle* request,
27 const BoundNetLog& net_log); 27 const BoundNetLog& net_log);
28 28
29 virtual void CancelRequest(RequestHandle request) { 29 virtual void CancelRequest(RequestHandle request) {
30 NOTREACHED(); 30 NOTREACHED();
31 } 31 }
32 32
33 private: 33 private:
34 virtual int SetPacScript(const GURL& pac_url, 34 virtual int SetPacScript(const GURL& pac_url,
35 const std::string& /*pac_bytes*/, 35 const string16& /*pac_script*/,
36 CompletionCallback* /*callback*/) { 36 CompletionCallback* /*callback*/) {
37 pac_url_ = pac_url; 37 pac_url_ = pac_url;
38 return OK; 38 return OK;
39 } 39 }
40 40
41 GURL pac_url_; 41 GURL pac_url_;
42 }; 42 };
43 43
44 } // namespace net 44 } // namespace net
45 45
46 #endif // NET_PROXY_PROXY_RESOLVER_MAC_H_ 46 #endif // NET_PROXY_PROXY_RESOLVER_MAC_H_
OLDNEW
« no previous file with comments | « net/proxy/proxy_resolver.h ('k') | net/proxy/proxy_resolver_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698