Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2817038: Explicitly reply no update for factory clients w/o update. (Closed)

Created:
10 years, 5 months ago by Nick Sanders
Modified:
9 years, 7 months ago
Reviewers:
Tammo Spalink, adlr
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/dev-util.git
Visibility:
Public.

Description

Explicitly reply no update for factory clients w/o update. BUG=None TEST='factory install w/o firmware or extra rootfs: no exception on server or client.'

Patch Set 1 #

Total comments: 2

Patch Set 2 : add break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M autoupdate.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nick Sanders
For channels or configs which don't have images, reply "no update". This allows dogfood installs ...
10 years, 5 months ago (2010-06-29 05:42:35 UTC) #1
adlr
LGTM w/ nit http://codereview.chromium.org/2817038/diff/1/2 File autoupdate.py (right): http://codereview.chromium.org/2817038/diff/1/2#newcode266 autoupdate.py:266: return (None, None, None) nit: might ...
10 years, 5 months ago (2010-06-29 17:20:38 UTC) #2
Nick Sanders
10 years, 5 months ago (2010-06-30 05:11:57 UTC) #3
http://codereview.chromium.org/2817038/diff/1/2
File autoupdate.py (right):

http://codereview.chromium.org/2817038/diff/1/2#newcode266
autoupdate.py:266: return (None, None, None)
On 2010/06/29 17:20:38, adlr wrote:
> nit: might be slightly cleaner to 'break' here rather than duplicate the
return
> line.

Done.

Powered by Google App Engine
This is Rietveld 408576698