Issue 2817036: Push change for stevenjb:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2817036: Push change for stevenjb:... (Closed)

Created:
10 years, 5 months ago by Charlie Lee

Modified:
9 years, 7 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Push change for stevenjb: Issue 2848016: Store wifi network in network_menu_button.cc as a path instead of as a struct. Store wifi network in network_menu_button.cc as a path instead of as a struct. This should address a potential edge case where wifi network information gets updated after the menu is opened and before a network is selected. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51064

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -37 lines)			Patch
M	.gitignore	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_network_library.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View	4 chunks	+29 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	4 chunks	+44 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.h	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View	13 chunks	+33 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2010/06/28 22:56:20, chocobo wrote:
> 

lgtm

Expand Messages | Collapse Messages