Issue 2817025: Automated version generation for vboot firmware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2817025: Automated version generation for vboot firmware. (Closed)

Created:
10 years, 6 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, gauravsh

CC:
chromium-os-reviews_chromium.org, Luigi Semenzato, Bill Richardson, Randall Spangler, gauravsh

Base URL:
ssh://git@chromiumos-git/vboot_reference.git

Visibility:
Public.

Description

Automated version generation for vboot firmware.

Patch Set 1 #

Patch Set 2 : Version ochange due to merging #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	firmware/Makefile	View		1 chunk	+12 lines, -2 lines	0 comments	Download
	A	firmware/version.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

Same code as tpm_lite. Please let me know if I am including all relevant files ...

10 years, 6 months ago (2010-06-23 23:23:02 UTC) #1

FYI (non scoring comment) It is great that the version advances only when needed, it ...

10 years, 6 months ago (2010-06-24 14:54:48 UTC) #4

Luigi Semenzato

10 years, 6 months ago (2010-06-24 15:04:43 UTC) #5

Thank you for the suggestion.  I didn't think that would be possible,
but I just realized that an auto-advancing version number, or a time
stamp, following the hash would do the trick.

It's also fairly easy to produce a table of versions with their dates,
and just search through it.

On Thu, Jun 24, 2010 at 7:54 AM,  <vbendeb@chromium.org> wrote:
> FYI (non scoring comment)
>
> It is great that the version advances only when needed, it
> would be even better if it was possible to tell which
> version is newer by looking at the version string.
>
> Could be left as a future enhancement.
>
> http://codereview.chromium.org/2817025/show
>

Expand Messages | Collapse Messages