Small tweaks to improve toolbar keyboard accessibility: Put focus rects...

views/controls/button/menu_button.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/button/menu_button.h"
 
 #include "app/drag_drop_types.h"
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "gfx/canvas.h"
@@ skipping 208 matching lines @@
       e.GetKeyCode() == base::VKEY_UP ||
       e.GetKeyCode() == base::VKEY_DOWN) {
     bool result = Activate();
     if (GetFocusManager()->GetFocusedView() == NULL)
       RequestFocus();
     return result;
   }
   return false;
 }
 
+bool MenuButton::OnKeyReleased(const KeyEvent& e) {
+  // Override CustomButton's implementation, which presses the button when
+  // you press space and clicks it when you release space.  For a MenuButton
+  // we always activate the menu on key press.
+  return false;
+}
+
 // The reason we override View::OnMouseExited is because we get this event when
 // we display the menu. If we don't override this method then
 // BaseButton::OnMouseExited will get the event and will set the button's state
 // to BS_NORMAL instead of keeping the state BM_PUSHED. This, in turn, will
 // cause the button to appear depressed while the menu is displayed.
 void MenuButton::OnMouseExited(const MouseEvent& event) {
   if ((state_ != BS_DISABLED) && (!menu_visible_) && (!InDrag())) {
     SetState(BS_NORMAL);
   }
 }
@@ skipping 23 matching lines @@
 
   *state = AccessibilityTypes::STATE_HASPOPUP;
   return true;
 }
 
 std::string MenuButton::GetClassName() const {
   return kViewClassName;
 }
 
 }  // namespace views