Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3069)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/site_instance_unittest.cc

Issue 28170: More URL constants replacement. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc ('k') | chrome/browser/tab_contents/navigation_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/site_instance_unittest.cc
===================================================================
--- chrome/browser/site_instance_unittest.cc (revision 10412)
+++ chrome/browser/site_instance_unittest.cc (working copy)
@@ -241,9 +241,9 @@
GURL url_foo_https = GURL("https://foo/a.html");
GURL url_foo_port = GURL("http://foo:8080/a.html");
GURL url_javascript = GURL("javascript:alert(1);");
- GURL url_crash = GURL("about:crash");
- GURL url_hang = GURL("about:hang");
- GURL url_shorthang = GURL("about:shorthang");
+ GURL url_crash = GURL(chrome::kAboutCrashURL);
+ GURL url_hang = GURL(chrome::kAboutHangURL);
+ GURL url_shorthang = GURL(chrome::kAboutShortHangURL);
// Same scheme and port -> same site.
EXPECT_TRUE(SiteInstance::IsSameWebSite(url_foo, url_foo2));
« no previous file with comments | « chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc ('k') | chrome/browser/tab_contents/navigation_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698