Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 28170: More URL constants replacement. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser.cc ('k') | chrome/browser/crash_recovery_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_about_handler.cc
===================================================================
--- chrome/browser/browser_about_handler.cc (revision 10437)
+++ chrome/browser/browser_about_handler.cc (working copy)
@@ -162,7 +162,7 @@
// about:blank is special. Frames are allowed to access about:blank,
// but they are not allowed to access other types of about pages.
// Just ignore the about:blank and let the TAB_CONTENTS_WEB handle it.
- if (StringToLowerASCII(url->path()) == "blank") {
+ if (LowerCaseEqualsASCII(url->spec(), chrome::kAboutBlankURL)) {
return false;
}
@@ -185,7 +185,7 @@
// Navigate the renderer to about:blank. This is kind of stupid but is the
// easiest thing to do in this situation without adding a lot of complexity
// for this developer-only feature.
- *url = GURL("about:blank");
+ *url = GURL(chrome::kAboutBlankURL);
return false;
}
@@ -198,7 +198,7 @@
NOTIMPLEMENTED();
// TODO(port) Implement this.
#endif
- *url = GURL("about:blank");
+ *url = GURL(chrome::kAboutBlankURL);
return false;
}
#endif
« no previous file with comments | « chrome/browser/browser.cc ('k') | chrome/browser/crash_recovery_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698