chrome/browser/renderer_host/renderer_security_policy_unittest.cc - Issue 28170: More URL constants replacement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/renderer_security_policy_unittest.cc

Issue 28170: More URL constants replacement. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/renderer_host/renderer_security_policy_unittest.cc

===================================================================

--- chrome/browser/renderer_host/renderer_security_policy_unittest.cc (revision 10412)

+++ chrome/browser/renderer_host/renderer_security_policy_unittest.cc (working copy)

@@ -87,26 +87,26 @@

EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("aBouT:BlAnK")));

EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("aBouT:blank")));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:memory")));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:crash")));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:cache")));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:hang")));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutMemoryURL)));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutCrashURL)));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutCacheURL)));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutHangURL)));

EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("aBoUt:memory")));

EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:CrASh")));

EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("abOuT:cAChe")));

- p->GrantRequestURL(kRendererID, GURL("about:memory"));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:memory")));

+ p->GrantRequestURL(kRendererID, GURL(chrome::kAboutMemoryURL));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutMemoryURL)));

- p->GrantRequestURL(kRendererID, GURL("about:crash"));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:crash")));

+ p->GrantRequestURL(kRendererID, GURL(chrome::kAboutCrashURL));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutCrashURL)));

- p->GrantRequestURL(kRendererID, GURL("about:cache"));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:cache")));

+ p->GrantRequestURL(kRendererID, GURL(chrome::kAboutCacheURL));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutCacheURL)));

- p->GrantRequestURL(kRendererID, GURL("about:hang"));

- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:hang")));

+ p->GrantRequestURL(kRendererID, GURL(chrome::kAboutHangURL));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutHangURL)));

p->Remove(kRendererID);

}