Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/history/history.cc

Issue 28170: More URL constants replacement. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/crash_recovery_uitest.cc ('k') | chrome/browser/history/url_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history.cc
===================================================================
--- chrome/browser/history/history.cc (revision 10412)
+++ chrome/browser/history/history.cc (working copy)
@@ -578,8 +578,7 @@
return false;
if (url.SchemeIs(chrome::kAboutScheme)) {
- std::string path = url.path();
- if (path.empty() || LowerCaseEqualsASCII(path, "blank"))
+ if (LowerCaseEqualsASCII(url.spec(), chrome::kAboutBlankURL))
return false;
// We allow all other about URLs since the user may like to see things
// like "about:memory" or "about:histograms" in their history and
« no previous file with comments | « chrome/browser/crash_recovery_uitest.cc ('k') | chrome/browser/history/url_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698