Issue 28162: Fix 8063: Find-in-page remains open on History/Downloads page...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28162: Fix 8063: Find-in-page remains open on History/Downloads page... (Closed)

Created:
11 years, 10 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix 8063: Find-in-page remains open on History/Downloads page. Added a UI test to catch this in the future. Also, in some of the UI tests I added a generic URL for pages that don't care about the content of the page and are just testing visibility of the Find box, etc. TEST=Covered by tests already. BUG=8063 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10490

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -6 lines)			Patch
M	chrome/browser/views/find_bar_win.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/views/find_bar_win_uitest.cc	View	4 chunks	+42 lines, -2 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages