zlib decompression for chromoting

zlib decompression for chromoting

Using zlib for decompression. Also revised the API and usage of zlib
for compression.

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51785

[dmac, 2010-07-02 19:16:32]

http://codereview.chromium.org/2815043/diff/1/2
File remoting/base/compressor.h (right):

http://codereview.chromium.org/2815043/diff/1/2#newcode34
remoting/base/compressor.h:34: // useful for the end of compression stream.
end of the compression stream.

http://codereview.chromium.org/2815043/diff/1/3
File remoting/base/compressor_zlib.cc (right):

http://codereview.chromium.org/2815043/diff/1/3#newcode57
remoting/base/compressor_zlib.cc:57: // Since we check for |output_size| to be
greater than 0. The only
can we fix up the English in this sentence?

http://codereview.chromium.org/2815043/diff/1/5
File remoting/base/compressor_zlib_unittest.cc (right):

http://codereview.chromium.org/2815043/diff/1/5#newcode24
remoting/base/compressor_zlib_unittest.cc:24: int consumed, written;
are we going to get potential warnings about uninitialized values here if we
tighten up the warnings? do you just want to initialize these to zero to be
safe?

http://codereview.chromium.org/2815043/diff/1/6
File remoting/base/decompressor.h (right):

http://codereview.chromium.org/2815043/diff/1/6#newcode13
remoting/base/decompressor.h:13: // a Decompressor.
a compressor

http://codereview.chromium.org/2815043/diff/1/6#newcode15
remoting/base/decompressor.h:15: // Note that a Dedecompressor can only be used
on one stream during its
dedecompressor?

http://codereview.chromium.org/2815043/diff/1/6#newcode33
remoting/base/decompressor.h:33: virtual bool Write(const uint8* input_data, int
input_size,
is it wrong of me to think that this routine should be called "Read"? Or maybe
we should change the names completely to "Compress" and "Decompress" instead of
Write/Read which has slightly confusing semantics.

[Alpha Left Google, 2010-07-02 19:33:54]

http://codereview.chromium.org/2815043/diff/1/2
File remoting/base/compressor.h (right):

http://codereview.chromium.org/2815043/diff/1/2#newcode34
remoting/base/compressor.h:34: // useful for the end of compression stream.
On 2010/07/02 19:16:32, dmac wrote:
> end of the compression stream.

Done.

http://codereview.chromium.org/2815043/diff/1/3
File remoting/base/compressor_zlib.cc (right):

http://codereview.chromium.org/2815043/diff/1/3#newcode57
remoting/base/compressor_zlib.cc:57: // Since we check for |output_size| to be
greater than 0. The only
On 2010/07/02 19:16:32, dmac wrote:
> can we fix up the English in this sentence?

Done.

http://codereview.chromium.org/2815043/diff/1/5
File remoting/base/compressor_zlib_unittest.cc (right):

http://codereview.chromium.org/2815043/diff/1/5#newcode24
remoting/base/compressor_zlib_unittest.cc:24: int consumed, written;
On 2010/07/02 19:16:32, dmac wrote:
> are we going to get potential warnings about uninitialized values here if we
> tighten up the warnings? do you just want to initialize these to zero to be
> safe?

Done.

http://codereview.chromium.org/2815043/diff/1/6
File remoting/base/decompressor.h (right):

http://codereview.chromium.org/2815043/diff/1/6#newcode13
remoting/base/decompressor.h:13: // a Decompressor.
On 2010/07/02 19:16:32, dmac wrote:
> a compressor

Done.

http://codereview.chromium.org/2815043/diff/1/6#newcode15
remoting/base/decompressor.h:15: // Note that a Dedecompressor can only be used
on one stream during its
On 2010/07/02 19:16:32, dmac wrote:
> dedecompressor?

Done.

http://codereview.chromium.org/2815043/diff/1/6#newcode33
remoting/base/decompressor.h:33: virtual bool Write(const uint8* input_data, int
input_size,
On 2010/07/02 19:16:32, dmac wrote:
> is it wrong of me to think that this routine should be called "Read"? Or maybe
> we should change the names completely to "Compress" and "Decompress" instead
of
> Write/Read which has slightly confusing semantics.

calling compressor->Compressor and decompressor->Decompress seems to be
redundant to me..

may be process is better.

[dmac, 2010-07-02 22:14:11]

On 2010/07/02 19:33:54, Alpha wrote:
> http://codereview.chromium.org/2815043/diff/1/2
> File remoting/base/compressor.h (right):
> 
> http://codereview.chromium.org/2815043/diff/1/2#newcode34
> remoting/base/compressor.h:34: // useful for the end of compression stream.
> On 2010/07/02 19:16:32, dmac wrote:
> > end of the compression stream.
> 
> Done.
> 
> http://codereview.chromium.org/2815043/diff/1/3
> File remoting/base/compressor_zlib.cc (right):
> 
> http://codereview.chromium.org/2815043/diff/1/3#newcode57
> remoting/base/compressor_zlib.cc:57: // Since we check for |output_size| to be
> greater than 0. The only
> On 2010/07/02 19:16:32, dmac wrote:
> > can we fix up the English in this sentence?
> 
> Done.
> 
> http://codereview.chromium.org/2815043/diff/1/5
> File remoting/base/compressor_zlib_unittest.cc (right):
> 
> http://codereview.chromium.org/2815043/diff/1/5#newcode24
> remoting/base/compressor_zlib_unittest.cc:24: int consumed, written;
> On 2010/07/02 19:16:32, dmac wrote:
> > are we going to get potential warnings about uninitialized values here if we
> > tighten up the warnings? do you just want to initialize these to zero to be
> > safe?
> 
> Done.
> 
> http://codereview.chromium.org/2815043/diff/1/6
> File remoting/base/decompressor.h (right):
> 
> http://codereview.chromium.org/2815043/diff/1/6#newcode13
> remoting/base/decompressor.h:13: // a Decompressor.
> On 2010/07/02 19:16:32, dmac wrote:
> > a compressor
> 
> Done.
> 
> http://codereview.chromium.org/2815043/diff/1/6#newcode15
> remoting/base/decompressor.h:15: // Note that a Dedecompressor can only be
used
> on one stream during its
> On 2010/07/02 19:16:32, dmac wrote:
> > dedecompressor?
> 
> Done.
> 
> http://codereview.chromium.org/2815043/diff/1/6#newcode33
> remoting/base/decompressor.h:33: virtual bool Write(const uint8* input_data,
int
> input_size,
> On 2010/07/02 19:16:32, dmac wrote:
> > is it wrong of me to think that this routine should be called "Read"? Or
maybe
> > we should change the names completely to "Compress" and "Decompress" instead
> of
> > Write/Read which has slightly confusing semantics.
> 
> calling compressor->Compressor and decompressor->Decompress seems to be
> redundant to me..
> 
> may be process is better.

process sounds good.. or perform.

[Alpha Left Google, 2010-07-07 21:06:00]

ping.

[dmac, 2010-07-07 21:16:14]

LGTM