Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2815039: ARM: Correctness fix to Math.pow optimization... (Closed)

Created:
10 years, 5 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

ARM: Correctness fix to Math.pow optimization The change in r4990 contained a bug in Math.pow when then exponent was a large negative smi. In that case calculating 1/Math.pow(x,-y) did not provide the correct result as Math.pow(x,-y) would overflow ti infinity. This was caught by Sputnik test S8.5_A13_T1. Committed: http://code.google.com/p/v8/source/detail?r=4994

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/arm/codegen-arm.cc View 1 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
10 years, 5 months ago (2010-06-30 15:05:30 UTC) #1
Erik Corry
LGTM. We should have this test in our own test suite too.
10 years, 5 months ago (2010-06-30 15:10:53 UTC) #2
Søren Thygesen Gjesse
10 years, 5 months ago (2010-06-30 15:20:17 UTC) #3
On 2010/06/30 15:10:53, Erik Corry wrote:
> LGTM.  We should have this test in our own test suite too.

The following tests from Sputnik S8.5_A13_T1 are added to mjsunit test
math-pow.js.

assertTrue((1*((Math.pow(2,53))-1)*(Math.pow(2,-1074))) ===
4.4501477170144023e-308);
assertTrue((1*(Math.pow(2,52))*(Math.pow(2,-1074))) ===
2.2250738585072014e-308);
assertTrue((-1*(Math.pow(2,52))*(Math.pow(2,-1074))) ===
-2.2250738585072014e-308);

Powered by Google App Engine
This is Rietveld 408576698