Issue 2815017: Revert r50367 "Move DEPS parsing into a single function." yet again...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2815017: Revert r50367 "Move DEPS parsing into a single function." yet again... (Closed)

Created:
10 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
nasserg, Mandeep Singh Baines, bradnelson, bradn

CC:
chromium-reviews

Visibility:
Public.

Description

Revert r50367 "Move DEPS parsing into a single function." yet again... TBR=nasserg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50372

Patch Set 1 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -104 lines)			Patch
M	gclient.py	View	13 chunks	+95 lines, -70 lines	2 comments	Download
M	tests/fake_repos.py	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/gclient_smoketest.py	View	4 chunks	+1 line, -28 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

LGTM http://codereview.chromium.org/2815017/diff/1/2 File gclient.py (right): http://codereview.chromium.org/2815017/diff/1/2#newcode189 gclient.py:189: custom_vars: A dict of vars to override any ...

10 years, 6 months ago (2010-06-22 04:51:00 UTC) #2

M-A Ruel

Hopefully my third try of http://codereview.chromium.org/2839008 will work. http://codereview.chromium.org/2815017/diff/1/2 File gclient.py (right): http://codereview.chromium.org/2815017/diff/1/2#newcode189 gclient.py:189: custom_vars: ...

10 years, 6 months ago (2010-06-22 14:29:10 UTC) #3

bradn

10 years, 6 months ago (2010-06-22 14:31:56 UTC) #4

SGTM

On Tue, Jun 22, 2010 at 7:29 AM, <maruel@chromium.org> wrote:

> Hopefully my third try of http://codereview.chromium.org/2839008 will
> work.
>
>
>
> http://codereview.chromium.org/2815017/diff/1/2
> File gclient.py (right):
>
> http://codereview.chromium.org/2815017/diff/1/2#newcode189
> gclient.py:189: custom_vars: A dict of vars to override any vars defined
> in the DEPS file.
> On 2010/06/22 04:51:00, bradn wrote:
>
>> Missing some args here.
>>
>
> Well, the goal is to delete this code if I can stop breaking everyone...
>
>
> http://codereview.chromium.org/2815017/show
>

Expand Messages | Collapse Messages