Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Side by Side Diff: chrome/browser/translate/translate_infobar_delegate2.cc

Issue 2815013: Refactor the translate infobars on mac to match the new windows code. (Closed)
Patch Set: Move unittest stuff back to class files Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/translate/translate_infobar_delegate2.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 6
7 #include "chrome/browser/translate/translate_infobar_delegate2.h" 7 #include "chrome/browser/translate/translate_infobar_delegate2.h"
8 8
9 #include "app/l10n_util.h" 9 #include "app/l10n_util.h"
10 #include "app/resource_bundle.h" 10 #include "app/resource_bundle.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 (type_ == TRANSLATION_ERROR && error != TranslateErrors::NONE)); 50 (type_ == TRANSLATION_ERROR && error != TranslateErrors::NONE));
51 51
52 std::vector<std::string> language_codes; 52 std::vector<std::string> language_codes;
53 TranslateManager2::GetSupportedLanguages(&language_codes); 53 TranslateManager2::GetSupportedLanguages(&language_codes);
54 54
55 languages_.reserve(language_codes.size()); 55 languages_.reserve(language_codes.size());
56 for (std::vector<std::string>::const_iterator iter = language_codes.begin(); 56 for (std::vector<std::string>::const_iterator iter = language_codes.begin();
57 iter != language_codes.end(); ++iter) { 57 iter != language_codes.end(); ++iter) {
58 std::string language_code = *iter; 58 std::string language_code = *iter;
59 59
60 if (language_code == original_language)
61 original_language_index_ = iter - language_codes.begin();
62 else if (language_code == target_language)
63 target_language_index_ = iter - language_codes.begin();
64
65 string16 language_name = GetLanguageDisplayableName(language_code); 60 string16 language_name = GetLanguageDisplayableName(language_code);
66 // Insert the language in languages_ in alphabetical order. 61 // Insert the language in languages_ in alphabetical order.
67 std::vector<LanguageNamePair>::iterator iter2; 62 std::vector<LanguageNamePair>::iterator iter2;
68 for (iter2 = languages_.begin(); iter2 != languages_.end(); ++iter2) { 63 for (iter2 = languages_.begin(); iter2 != languages_.end(); ++iter2) {
69 if (language_name.compare(iter2->second) < 0) 64 if (language_name.compare(iter2->second) < 0)
70 break; 65 break;
71 } 66 }
72 languages_.insert(iter2, LanguageNamePair(language_code, language_name)); 67 languages_.insert(iter2, LanguageNamePair(language_code, language_name));
73 } 68 }
69 for (std::vector<LanguageNamePair>::const_iterator iter = languages_.begin();
70 iter != languages_.end(); ++iter) {
71 std::string language_code = iter->first;
72 if (language_code == original_language)
73 original_language_index_ = iter - languages_.begin();
74 else if (language_code == target_language)
75 target_language_index_ = iter - languages_.begin();
76 }
77
74 DCHECK(original_language_index_ != -1); 78 DCHECK(original_language_index_ != -1);
75 DCHECK(target_language_index_ != -1); 79 DCHECK(target_language_index_ != -1);
76 } 80 }
77 81
78 int TranslateInfoBarDelegate2::GetLanguageCount() const { 82 int TranslateInfoBarDelegate2::GetLanguageCount() const {
79 return static_cast<int>(languages_.size()); 83 return static_cast<int>(languages_.size());
80 } 84 }
81 85
82 const std::string& TranslateInfoBarDelegate2::GetLanguageCodeAt( 86 const std::string& TranslateInfoBarDelegate2::GetLanguageCodeAt(
83 int index) const { 87 int index) const {
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 *swap_languages = true; 297 *swap_languages = true;
294 } else { 298 } else {
295 *swap_languages = false; 299 *swap_languages = false;
296 } 300 }
297 301
298 strings->push_back(text.substr(0, offsets[0])); 302 strings->push_back(text.substr(0, offsets[0]));
299 strings->push_back(text.substr(offsets[0], offsets[1])); 303 strings->push_back(text.substr(offsets[0], offsets[1]));
300 strings->push_back(text.substr(offsets[1])); 304 strings->push_back(text.substr(offsets[1]));
301 } 305 }
302 306
303 #if !defined(OS_WIN) && !defined(OS_CHROMEOS) 307 #if !defined(OS_WIN) && !defined(OS_CHROMEOS) && !defined(OS_MACOSX)
304 // Necessary so we link OK on Mac and Linux while the new translate infobars 308 // Necessary so we link OK on Mac and Linux while the new translate infobars
305 // are being ported to these platforms. 309 // are being ported to these platforms.
306 InfoBar* TranslateInfoBarDelegate2::CreateInfoBar() { 310 InfoBar* TranslateInfoBarDelegate2::CreateInfoBar() {
307 return NULL; 311 return NULL;
308 } 312 }
309 #endif 313 #endif
OLDNEW
« no previous file with comments | « chrome/browser/translate/translate_infobar_delegate2.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698