Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2815003: ARM: Change code generation for function return... (Closed)

Created:
10 years, 6 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

ARM: Change code generation for function return Generating code for function return on ARM is now aligned with the other platforms. The first non-shadowed return statement encountered will emit code for function return and all other returns including the fall through at the bottom of a function will jump to that. Committed: http://code.google.com/p/v8/source/detail?r=4856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -53 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +68 lines, -49 lines 0 comments Download
M src/arm/virtual-frame-arm.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/virtual-frame-light-inl.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 6 months ago (2010-06-14 10:16:45 UTC) #1
Erik Corry
10 years, 6 months ago (2010-06-14 11:16:19 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698