Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2814050: Version 2.2.23... (Closed)

Created:
10 years, 5 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Version 2.2.23 API change: Convert Unicode code points outside the basic multilingual plane to the replacement character. Previous behavior was to silently truncate the value to 16 bits. Fixed crash: handle all flat string types in regexp replace. Prevent invalid pre-parsing data passed in through the API from crashing V8. Performance improvements on all platforms. Committed: http://code.google.com/p/v8/source/detail?r=5033

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+839 lines, -475 lines) Patch
M ChangeLog View 1 chunk +13 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 6 chunks +193 lines, -185 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/codegen.h View 2 chunks +19 lines, -6 lines 0 comments Download
M src/codegen.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/date.js View 11 chunks +54 lines, -133 lines 0 comments Download
M src/debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.h View 1 chunk +8 lines, -4 lines 0 comments Download
M src/factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 7 chunks +20 lines, -11 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 8 chunks +24 lines, -42 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/ic.cc View 2 chunks +59 lines, -5 lines 0 comments Download
M src/macros.py View 1 chunk +4 lines, -0 lines 0 comments Download
M src/messages.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 7 chunks +19 lines, -4 lines 0 comments Download
M src/objects.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M src/objects-inl.h View 2 chunks +18 lines, -3 lines 0 comments Download
M src/parser.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M src/runtime.cc View 7 chunks +143 lines, -5 lines 0 comments Download
M src/spaces.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 8 chunks +27 lines, -33 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M test/mjsunit/fuzz-natives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/math-min-max.js View 1 chunk +10 lines, -1 line 0 comments Download
A test/mjsunit/string-replace-with-empty.js View 1 chunk +57 lines, -0 lines 0 comments Download
A test/mjsunit/value-of.js View 1 chunk +33 lines, -0 lines 0 comments Download
M tools/js2c.py View 5 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years, 5 months ago (2010-07-07 12:17:24 UTC) #1
William Hesse
10 years, 5 months ago (2010-07-07 12:22:30 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698