Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2814047: Cleanup: Remove about:network.... (Closed)

Created:
10 years, 5 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Cleanup: Remove about:network. This about page was only being enabled for non-official windows builds as its UI wasn't cross platform. Its functionality is now superceded by about:net-internals (which works cross platform and is enabled for all builds). In fact at some point we might consider renaming about:net-internals to about:network. BUG=25557 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -458 lines) Patch
M chrome/browser/browser_about_handler.cc View 2 chunks +1 line, -11 lines 0 comments Download
D chrome/browser/views/about_network_dialog.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/views/about_network_dialog.cc View 1 chunk +0 lines, -379 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
eroman
10 years, 5 months ago (2010-07-02 20:44:37 UTC) #1
darin (slow to review)
10 years, 5 months ago (2010-07-02 21:02:39 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698