Issue 2814040: rootdev.c: Added -d option to strip trailing partition number

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2814040: rootdev.c: Added -d option to strip trailing partition number (Closed)

Created:
10 years, 5 months ago by kobi

Modified:
9 years, 7 months ago

Reviewers:
Bill Richardson, brian d

CC:
chromium-os-reviews_chromium.org, vb

Base URL:
http://src.chromium.org/git/rootdev.git

Visibility:
Public.

Description

rootdev.c: Added -d option to strip trailing partition number Change-Id: I2afbb0a8546f48224292433e2efcf0a868c7a1c6

Patch Set 2 : rootdev.c: Address comment from Bill. (--len in nl) #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -9 lines)			Patch
	M	rootdev.c	View	1	3 chunks	+40 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

LGTM http://codereview.chromium.org/2814040/diff/1/2 File rootdev.c (right): http://codereview.chromium.org/2814040/diff/1/2#newcode43 rootdev.c:43: if (dirnamebuf[len-1] == 'p') --len; put the "--len" ...

10 years, 5 months ago (2010-06-30 15:59:34 UTC) #2

kobi

Sorry for the delay. Will submit autotest py script for rootdev shortly as well. (in ...

10 years, 5 months ago (2010-07-14 22:53:45 UTC) #4

LGTM.

On 2010/07/23 23:22:52, kobi wrote:
> Ping?

Expand Messages | Collapse Messages

Issue 2814040: rootdev.c: Added -d option to strip trailing partition number (Closed)

Description

Patch Set 1 #

Patch Set 2 : rootdev.c: Address comment from Bill. (--len in nl) #

Messages