Issue 2814021: X64: Reapply fix for allocating HeapNumber results for >>>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2814021: X64: Reapply fix for allocating HeapNumber results for >>>. (Closed)

Created:
10 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Reapply fix for allocating HeapNumber results for >>>. Also skip case where both number arguments are smis.

Patch Set 2 : Addressed review comments. #

Created: 10 years, 6 months ago

		Unified diffs	Side-by-side diffs	Stats (+106 lines, -32 lines)
	M	src/x64/codegen-x64.cc	View	10 chunks	+106 lines, -32 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. http://codereview.chromium.org/2814021/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2814021/diff/1/2#newcode10500 src/x64/codegen-x64.cc:10500: FloatingPointHelper::LoadAsIntegers(masm, We should probably add a specialized LoadNumbersAsIntegers, ...

10 years, 6 months ago (2010-06-21 10:57:11 UTC) #2

Lasse Reichstein

Addressed review comments. http://codereview.chromium.org/2814021/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2814021/diff/1/2#newcode10500 src/x64/codegen-x64.cc:10500: FloatingPointHelper::LoadAsIntegers(masm, Done. http://codereview.chromium.org/2814021/diff/1/2#newcode10544 src/x64/codegen-x64.cc:10544: // Allocate ...

10 years, 6 months ago (2010-06-21 11:18:08 UTC) #3

LGTM.

Expand Messages | Collapse Messages

Issue 2814021: X64: Reapply fix for allocating HeapNumber results for >>>. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments. #

Messages