Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9782)

Unified Diff: chrome/renderer/renderer_about_handler_unittest.cc

Issue 2814012: Split part of about_handler into chrome/common to break the browser-renderer ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: with unit test Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/about_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/renderer_about_handler_unittest.cc
===================================================================
--- chrome/renderer/renderer_about_handler_unittest.cc (revision 0)
+++ chrome/renderer/renderer_about_handler_unittest.cc (revision 0)
@@ -0,0 +1,20 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/about_handler.h"
+#include "chrome/renderer/about_handler.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+// This is just to make sure the about_urls array in
+// chrome/common/about_handler.cc matches up with the about_urls_handlers
+// in chrome/renderer/about_handler.cc. They used to be in one array, but
+// we broke them apart to break a browser <-> renderer dependency.
+// We cannot test this with COMPILE_ASSERT because
+// chrome/renderer/about_handler.cc doesn't know about the size of about_urls
+// in chrome/common/about_handler.cc at compile time.
+
+TEST(RendererAboutHandlerTest, AboutUrlHandlerArray) {
+ ASSERT_EQ(chrome_about_handler::about_urls_size,
+ AboutHandler::AboutURLHandlerSize());
+}
Property changes on: chrome/renderer/renderer_about_handler_unittest.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/renderer/about_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698