Issue 2814012: Split part of about_handler into chrome/common to break the browser-renderer ...

Issue 2814012: Split part of about_handler into chrome/common to break the browser-renderer ... (Closed)

Created:
10 years, 6 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, jam+cc_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Split part of about_handler into chrome/common to break the browser-renderer dependency. BUG=46666 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50209

Patch Set 3 : with unit test #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -49 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View		6 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/browser/browser_about_handler_unittest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	chrome/common/about_handler.h	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/common/about_handler.cc	View	1 2	1 chunk	+34 lines, -0 lines	0 comments	Download
M	chrome/renderer/about_handler.h	View	1 2	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/renderer/about_handler.cc	View	1 2	2 chunks	+21 lines, -31 lines	0 comments	Download
A	chrome/renderer/renderer_about_handler_unittest.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/2814012/diff/1/6 File chrome/common/about_handler.h (right): http://codereview.chromium.org/2814012/diff/1/6#newcode13 chrome/common/about_handler.h:13: extern const char* about_urls[]; extern const char* const about_urls[]; ...

10 years, 6 months ago (2010-06-17 18:41:36 UTC) #2

Lei Zhang

10 years, 6 months ago (2010-06-17 20:07:48 UTC) #3

M-A Ruel

http://codereview.chromium.org/2814012/diff/1/7 File chrome/renderer/about_handler.cc (right): http://codereview.chromium.org/2814012/diff/1/7#newcode20 chrome/renderer/about_handler.cc:20: On 2010/06/17 20:07:48, Lei Zhang wrote: > On 2010/06/17 ...

10 years, 6 months ago (2010-06-17 20:10:37 UTC) #4

Lei Zhang

On 2010/06/17 20:10:37, Marc-Antoine Ruel wrote: > Can you do that in a unit test ...

10 years, 6 months ago (2010-06-17 21:07:45 UTC) #5

M-A Ruel

10 years, 6 months ago (2010-06-18 01:32:05 UTC) #6

it's fine enough with me, it will catch obvious errors.

lgtm

Expand Messages | Collapse Messages