Issue 2814005: Landing CL http://codereview.chromium.org/2767013/show on behalf of petkov@ch...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2814005: Landing CL http://codereview.chromium.org/2767013/show on behalf of petkov@ch... (Closed)

Created:
10 years, 6 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Landing CL http://codereview.chromium.org/2767013/show on behalf of petkov@chromium.org: Add one more Chrome OS hardware class MetricsLog unit tests. Since the hardware class attribute is added to the XML when the log is closed, it's important to test for its presence in the encoded string when the log contains some events. The existing unit test covers only the case when the log is empty. BUG=none TEST=ran unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49980

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	chrome/browser/metrics/metrics_log_unittest.cc	View		1 chunk	+31 lines, -0 lines	0 comments	Download