Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 28136: Fixing WebKeyboardEvent. For reals this time. (Closed)

Created:
11 years, 10 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixing WebKeyboardEvent. For reals this time. A recommit of http://codereview.chromium.org/27056 . Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10464

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -305 lines) Patch
M chrome/browser/renderer_host/render_view_host.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_view_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/SConscript View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/event_conversion.cc View 1 2 3 chunks +11 lines, -161 lines 0 comments Download
M webkit/glue/glue.vcproj View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/glue/webinputevent.h View 1 2 6 chunks +72 lines, -34 lines 0 comments Download
M webkit/glue/webinputevent_linux.cc View 1 2 5 chunks +20 lines, -15 lines 0 comments Download
M webkit/glue/webinputevent_mac.mm View 1 2 3 chunks +45 lines, -17 lines 0 comments Download
A webkit/glue/webinputevent_utils.h View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/glue/webinputevent_utils.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M webkit/glue/webinputevent_win.cc View 1 2 4 chunks +21 lines, -8 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 2 10 chunks +16 lines, -29 lines 0 comments Download
M webkit/glue/webwidget_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/event_sending_controller.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/keyboard_unittest.cc View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/mac/webwidget_host.mm View 1 2 1 chunk +1 line, -9 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host_gtk.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
Changes from last time: - Header rearrangement in webinputevent_win.cc into something sane that didn't involved ...
11 years, 10 months ago (2009-02-25 22:29:13 UTC) #1
Avi (use Gerrit)
BTW, I was just massively thwarted by http://codereview.chromium.org/28105 which adds more platform-dependence to WebKeyboardEvent. What ...
11 years, 10 months ago (2009-02-25 22:39:40 UTC) #2
darin (slow to review)
11 years, 10 months ago (2009-02-26 04:17:46 UTC) #3 
LGTM

Powered by Google App Engine
This is Rietveld 408576698