Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4218)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 2813037: Revert 50917 - Added an about:about page (continuation)... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/url_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_about_handler.cc
===================================================================
--- chrome/browser/browser_about_handler.cc (revision 50921)
+++ chrome/browser/browser_about_handler.cc (working copy)
@@ -86,7 +86,6 @@
// The (alphabetized) paths used for the about pages.
const char kCreditsPath[] = "credits";
-const char kCachePath[] = "cache";
const char kDnsPath[] = "dns";
const char kHistogramsPath[] = "histograms";
const char kMemoryRedirectPath[] = "memory-redirect";
@@ -97,10 +96,6 @@
const char kTcmallocPath[] = "tcmalloc";
const char kTermsPath[] = "terms";
const char kVersionPath[] = "version";
-const char kAboutPath[] = "about";
-// Not about:* pages, but included to make about:about look nicer
-const char kNetInternalsPath[] = "net-internals";
-const char kPluginsPath[] = "plugins";
#if defined(OS_LINUX)
const char kLinuxProxyConfigPath[] = "linux-proxy-config";
@@ -112,31 +107,6 @@
const char kSysPath[] = "system";
#endif
-// Add path here to be included in about:about
-const char *kAllAboutPaths[] = {
- kCachePath,
- kCreditsPath,
- kDnsPath,
- kHistogramsPath,
- kMemoryPath,
- kNetInternalsPath,
- kPluginsPath,
- kStatsPath,
- kSyncPath,
- kTasksPath,
- kTcmallocPath,
- kTermsPath,
- kVersionPath,
-#if defined(OS_LINUX)
- kLinuxProxyConfigPath,
-#endif
-#if defined(OS_CHROMEOS)
- kNetworkPath,
- kOSCreditPath,
- kSysPath,
-#endif
- };
-
// Points to the singleton AboutSource object, if any.
ChromeURLDataManager::DataSource* about_source = NULL;
@@ -235,37 +205,6 @@
// Individual about handlers ---------------------------------------------------
-std::string AboutAbout() {
- std::string html;
- html.append("<html><head><title>About Pages</title></head><body>\n");
- html.append("<h2>List of About pages</h2><ul>\n");
- for (size_t i = 0; i < arraysize(kAllAboutPaths); i++) {
- if (kAllAboutPaths[i] == kNetInternalsPath ||
- kAllAboutPaths[i] == kPluginsPath)
- html.append("<li><a href='chrome://");
- else
- html.append("<li><a href='chrome://about/");
- html.append(kAllAboutPaths[i]);
- html.append("/'>about:");
- html.append(kAllAboutPaths[i]);
- html.append("</a>\n");
- }
- const char *debug[] = { "crash", "hang", "shorthang" };
- html.append("</ul><h2>For Debug</h2>");
- html.append("</ul><p>The following pages are for debugging purposes only. "
- "Because they crash or hang the renderer, they're not linked "
- "directly; you can type them into the address bar if you need "
- "them.</p><ul>");
- for (size_t i = 0; i < arraysize(debug); i++) {
- html.append("<li>");
- html.append("about:");
- html.append(debug[i]);
- html.append("\n");
- }
- html.append("</ul></body></html>");
- return html;
-}
-
#if defined(OS_CHROMEOS)
std::string AboutNetwork(const std::string& query) {
int refresh;
@@ -801,8 +740,6 @@
} else if (path == kCreditsPath) {
response = ResourceBundle::GetSharedInstance().GetRawDataResource(
IDR_CREDITS_HTML).as_string();
- } else if (path == kAboutPath) {
- response = AboutAbout();
#if defined(OS_CHROMEOS)
} else if (path == kOSCreditsPath) {
response = ResourceBundle::GetSharedInstance().GetRawDataResource(
« no previous file with comments | « no previous file | chrome/common/url_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698