Issue 2813010: Revert 49862 - Measure loading time of several tabs....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2813010: Revert 49862 - Measure loading time of several tabs.... (Closed)

Created:
10 years, 6 months ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
Patrick Horn

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 49862 - Measure loading time of several tabs. This is a new set of ui tests to load several tabs, and look at how long it takes for a subset to finish loading. BUG=44129 TEST=none Review URL: http://codereview.chromium.org/2559001 TBR=pathorn@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49870

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -93 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View	3 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.h	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.cc	View	3 chunks	+3 lines, -51 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Patrick Horn

10 years, 6 months ago (2010-06-16 01:07:01 UTC) #2

LGTM.

From what I gathered on the IRC channel, the problem appears to be a problem
with the mac linker using too much memory, and generally linking few times gets
past the memory error.

I'm probably going to revert the revert.

Expand Messages | Collapse Messages