Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2813010: Revert 49862 - Measure loading time of several tabs.... (Closed)

Created:
10 years, 6 months ago by michaeln
Modified:
9 years, 7 months ago
Reviewers:
Patrick Horn
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 49862 - Measure loading time of several tabs. This is a new set of ui tests to load several tabs, and look at how long it takes for a subset to finish loading. BUG=44129 TEST=none Review URL: http://codereview.chromium.org/2559001 TBR=pathorn@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -93 lines) Patch
M chrome/browser/automation/automation_provider.h View 3 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 3 chunks +3 lines, -51 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
michaeln
10 years, 6 months ago (2010-06-16 00:35:13 UTC) #1
Patrick Horn
10 years, 6 months ago (2010-06-16 01:07:01 UTC) #2
LGTM.

From what I gathered on the IRC channel, the problem appears to be a problem
with the mac linker using too much memory, and generally linking few times gets
past the memory error.

I'm probably going to revert the revert.

Powered by Google App Engine
This is Rietveld 408576698