Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2691)

Unified Diff: chrome/browser/resources/options/advanced_options.js

Issue 2812063: Add starter code for 'Clear Browser Data' and 'Font Settings' overlay dialogs... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/advanced_options.js
===================================================================
--- chrome/browser/resources/options/advanced_options.js (revision 52920)
+++ chrome/browser/resources/options/advanced_options.js (working copy)
@@ -26,14 +26,10 @@
OptionsPage.showPageByName('content');
};
$('privacyClearDataButton').onclick = function(event) {
- // TODO(csilv): spawn clear data overlay dialog.
+ OptionsPage.showOverlay('clearBrowserDataOverlay');
};
$('proxiesConfigureButton').onclick = function(event) {
- if (cr.isMac) {
- chrome.send('showNetworkProxySettings');
- } else {
- // TODO(csilv): spawn network proxy settings sub-dialog.
- }
+ chrome.send('showNetworkProxySettings');
};
$('downloadLocationBrowseButton').onclick = function(event) {
chrome.send('selectDownloadLocation');
@@ -42,7 +38,7 @@
chrome.send('autoOpenFileTypesAction');
};
$('fontSettingsConfigureFontsOnlyButton').onclick = function(event) {
- // TODO(csilv): spawn font settings sub-dialog.
+ OptionsPage.showOverlay('fontSettingsOverlay');
};
$('certificatesManageButton').onclick = function(event) {
chrome.send('showManageSSLCertificates');
« no previous file with comments | « chrome/browser/resources/options.html ('k') | chrome/browser/resources/options/clear_browser_data_overlay.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698