Issue 2812034: Adding --repack and --headeronly options to vbutil_kernel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2812034: Adding --repack and --headeronly options to vbutil_kernel (Closed)

Created:
10 years, 5 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@chromiumos-git//vboot_reference.git

Visibility:
Public.

Description

Adding --repack and --headeronly options to vbutil_kernel The --repack option lets us sign a previously signed kernel blob with a new kernel data key. The --headeronly option is so we can emit the new verification header separately from the kernel blob. More work to come...

Patch Set 1 #

Total comments: 2

Patch Set 2 : respond to comments. #

Patch Set 3 : oops. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+330 lines, -108 lines)			Patch
M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	host/include/host_key.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	host/lib/host_key.c	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	host/linktest/main.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/vboot_common2_tests.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/vboot_common3_tests.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utility/vbutil_firmware.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utility/vbutil_kernel.c	View	1 2	18 chunks	+318 lines, -96 lines	0 comments	Download
M	utility/vbutil_keyblock.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

LGTM assuming 'header' is renamed to 'vblock' or 'vblob'. http://codereview.chromium.org/2812034/diff/1/10 File utility/vbutil_kernel.c (right): http://codereview.chromium.org/2812034/diff/1/10#newcode85 utility/vbutil_kernel.c:85: ...

10 years, 5 months ago (2010-07-01 00:41:40 UTC) #2

lgtm

Expand Messages | Collapse Messages