chrome/browser/views/options/options_window_view.cc - Issue 2812026: Auto-size the views version of the options dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/options/options_window_view.cc

Issue 2812026: Auto-size the views version of the options dialog. (Closed)

Patch Set: Fix autosizing issue with gtk pref pages in chromeos options dialog. Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/views/options/options_window_view.cc

diff --git a/chrome/browser/views/options/options_window_view.cc b/chrome/browser/views/options/options_window_view.cc

index 76c219b6ef4d5ca59fe05e210e851d43108cd8bf..70a043d58acf89f392f42e0bcdc6308d70e5fd8b 100644

--- a/chrome/browser/views/options/options_window_view.cc

+++ b/chrome/browser/views/options/options_window_view.cc

@@ -183,9 +183,9 @@ void OptionsWindowView::Layout() {

}

gfx::Size OptionsWindowView::GetPreferredSize() {

- return gfx::Size(views::Window::GetLocalizedContentsSize(

- IDS_OPTIONS_DIALOG_WIDTH_CHARS,

- IDS_OPTIONS_DIALOG_HEIGHT_LINES));

+ gfx::Size size(tabs_->GetPreferredSize());

+ size.Enlarge(2 * kDialogPadding, 2 * kDialogPadding);

+ return size;

}

void OptionsWindowView::ViewHierarchyChanged(bool is_add,