Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4479)

Unified Diff: chrome/common/extensions/docs/build/build.py

Issue 2812023: Make the extension API docs point out the minimum version that supports an API call. (Closed)
Patch Set: Rebase for checkin. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/build/build.py
diff --git a/chrome/common/extensions/docs/build/build.py b/chrome/common/extensions/docs/build/build.py
index 67957549c03f79b35584d0826c7593ed5dc8df77..e073a01dd690bda756146e9a740e28a51fc2ad9b 100755
--- a/chrome/common/extensions/docs/build/build.py
+++ b/chrome/common/extensions/docs/build/build.py
@@ -60,7 +60,7 @@ def RenderPage(name, test_shell):
p = Popen([test_shell, "--layout-tests", generator_url],
stdout=PIPE)
- # the remaining output will be the content of the generated page.
+ # The remaining output will be the content of the generated page.
result = p.stdout.read()
content_start = result.find(_expected_output_preamble)
@@ -75,9 +75,10 @@ def RenderPage(name, test_shell):
"\nAnd open it in chrome using the file: scheme.\n" +
"Look from javascript errors via the inspector.")
raise Exception("test_shell returned unexpected output: " + result)
- result = result[content_start:content_end + len(_expected_output_postamble)] + "\n"
+ postamble_length = len(_expected_output_postamble)
+ result = result[content_start:content_end + postamble_length] + "\n"
- # remove the trailing #EOF that test shell appends to the output.
+ # Remove the trailing #EOF that test shell appends to the output.
result = result.replace('#EOF', '')
# Remove page_shell
« no previous file with comments | « chrome/common/extensions/docs/browserAction.html ('k') | chrome/common/extensions/docs/content_scripts.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698